Skip to content

Enable str/Path as input to get_hdf5_datalevels#2451

Merged
maxnoe merged 1 commit into
mainfrom
path_input_h5_datalevels
Nov 22, 2023
Merged

Enable str/Path as input to get_hdf5_datalevels#2451
maxnoe merged 1 commit into
mainfrom
path_input_h5_datalevels

Conversation

@maxnoe

@maxnoe maxnoe commented Nov 6, 2023

Copy link
Copy Markdown
Member

Fixes #2450

@maxnoe maxnoe force-pushed the path_input_h5_datalevels branch from ecbda95 to 6f74957 Compare November 6, 2023 13:10
Tobychev
Tobychev previously approved these changes Nov 6, 2023
@maxnoe maxnoe force-pushed the path_input_h5_datalevels branch from ad71589 to 279614f Compare November 17, 2023 11:30
@codecov

codecov Bot commented Nov 17, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (49ab82b) 60.60% compared to head (279614f) 60.60%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2451   +/-   ##
=======================================
  Coverage   60.60%   60.60%           
=======================================
  Files           3        3           
  Lines          33       33           
=======================================
  Hits           20       20           
  Misses         13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe maxnoe merged commit a2b6072 into main Nov 22, 2023
@maxnoe maxnoe deleted the path_input_h5_datalevels branch November 22, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

get_hdf5_datalevels seems broken

3 participants